AIP-84 Migrate XCom get entries endpoint to Fastapi #44366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljs-c
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
rawwar
reviewed
Nov 25, 2024
rawwar
reviewed
Nov 26, 2024
michaeljs-c
force-pushed
the
migrate-xcom-getentries-to-fastapi
branch
2 times, most recently
from
fc6f1c9 to
b55992b
Compare
amoghrajesh
reviewed
Nov 26, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Looking nice @michaeljs-c! Two nits and we should be in a mergable state
Contributor
Author
|
Looking into CI failures |
Member
Hi @michaeljs-c, I think the current CI failure for static is cause by frontend generated code, which could be resolve by: refer: #43859 (comment) |
pierrejeambrun
approved these changes
Nov 26, 2024
pierrejeambrun
changed the title
amoghrajesh
approved these changes
Nov 26, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Thanks for explanation. LGTM
michaeljs-c
force-pushed
the
migrate-xcom-getentries-to-fastapi
branch
from
b55992b to
f413add
Compare
michaeljs-c
requested review from
bbovenzi,
jscheffl and
ryanahamilton
as code owners
Contributor
Author
Thanks! for some reason it got skipped during my initial pre-commit |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #42980
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.