Get rid of database isolation option #44441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
eladkal,
jedcunningham,
mobuchowski and
o-nikolas
as code owners
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:airbyte
provider:amazon
As part of removing AIP-44 we remove database isolation mode and remove pytest markers that skipped some tests. Part of apache#44436
potiuk
force-pushed
the
remove-database-isolation-mode
branch
from
1c3a6f2 to
3e09bbf
Compare
Member
Author
|
Seems it's green. |
rawwar
reviewed
Nov 28, 2024
Co-authored-by: Kalyan R <kalyan.ben10@live.com>
ashb
approved these changes
Nov 28, 2024
kaxil
approved these changes
Nov 28, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 28, 2024
This change removes all configuration that controls AIP-44 behaviour. It does not yet remove all the related code, this will be a follow up but it removes all the controls that determine if AIP-44 is enabled or not and removes all the Traceback Session/Disabling of DB session modifications that were used in "database isolation" mode. The "database isolation" mode has been disabled in apache#44441 so there was no easy way to enable it anyoway - this change removes the capability to use database isolation mode completely. Part of apache#44436
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 28, 2024
As part of removing AIP-44 we remove database isolation mode and remove pytest markers that skipped some tests. Part of apache#44436 --------- Co-authored-by: Kalyan R <kalyan.ben10@live.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 28, 2024
This change removes all configuration that controls AIP-44 behaviour. It does not yet remove all the related code, this will be a follow up but it removes all the controls that determine if AIP-44 is enabled or not and removes all the Traceback Session/Disabling of DB session modifications that were used in "database isolation" mode. The "database isolation" mode has been disabled in apache#44441 so there was no easy way to enable it anyoway - this change removes the capability to use database isolation mode completely. Part of apache#44436
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 28, 2024
This change removes all configuration that controls AIP-44 behaviour. It does not yet remove all the related code, this will be a follow up but it removes all the controls that determine if AIP-44 is enabled or not and removes all the Traceback Session/Disabling of DB session modifications that were used in "database isolation" mode. The "database isolation" mode has been disabled in apache#44441 so there was no easy way to enable it anyoway - this change removes the capability to use database isolation mode completely. Part of apache#44436
potiuk
added a commit
that referenced
this pull request
Nov 28, 2024
This change removes all configuration that controls AIP-44 behaviour. It does not yet remove all the related code, this will be a follow up but it removes all the controls that determine if AIP-44 is enabled or not and removes all the Traceback Session/Disabling of DB session modifications that were used in "database isolation" mode. The "database isolation" mode has been disabled in #44441 so there was no easy way to enable it anyoway - this change removes the capability to use database isolation mode completely. Part of #44436
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
As part of removing AIP-44 we remove database isolation mode and remove pytest markers that skipped some tests. Part of apache#44436 --------- Co-authored-by: Kalyan R <kalyan.ben10@live.com>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This change removes all configuration that controls AIP-44 behaviour. It does not yet remove all the related code, this will be a follow up but it removes all the controls that determine if AIP-44 is enabled or not and removes all the Traceback Session/Disabling of DB session modifications that were used in "database isolation" mode. The "database isolation" mode has been disabled in apache#44441 so there was no easy way to enable it anyoway - this change removes the capability to use database isolation mode completely. Part of apache#44436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of removing AIP-44 we remove database isolation mode and remove pytest markers that skipped some tests.
Part of #44436
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.