Skip to content

Conversation

@darkag
Copy link
Contributor

@darkag darkag commented Nov 29, 2024


closes: #42215

Fix gantt flickering issue. if someone can label it to legacy ui

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Nov 29, 2024
@jscheffl jscheffl added legacy ui Whether legacy UI change should be allowed in PR legacy api Whether legacy API changes should be allowed in PR labels Nov 29, 2024
@jscheffl jscheffl closed this Nov 29, 2024
@jscheffl jscheffl reopened this Nov 29, 2024
@jscheffl
Copy link
Contributor

Before merge - for local testing - can you tell me a good example DAG/run such that I can test it locally? I am sure I have seen it myself flickering but I'd like to ensure I am looking at the right place... as I did not note down where...

@darkag
Copy link
Contributor Author

darkag commented Nov 30, 2024

Sure, here is step to reproduce the issue with the the following dag

from __future__ import annotations

import pendulum

from airflow.decorators import dag, task
from airflow.operators.empty import EmptyOperator


# [START dag_decorator_usage]
@dag(
    schedule=None,
    start_date=pendulum.datetime(2021, 1, 1, tz="UTC"),
    catchup=False,
    tags=["example"],
    dag_display_name="Sample DAG with Display Name",
)
def example_display_name():
    sample_task_1 = EmptyOperator(
        task_id="sample_task_1",
        task_display_name="Sample Task 1",
    )

    @task(task_display_name="Sample Task 2")
    def sample_task_2():
        pass

    sample_task_1 >> sample_task_2()


example_dag = example_display_name()

trigger a dag run of this dag
clear "Sample task 2"

with the fix, the gantt gaph should look to something like this
image

without it will result as something like this:
2024-11-30 16-10-10

@jscheffl jscheffl added this to the Airflow 2.10.4 milestone Nov 30, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That really seems to work. Thanks for the fix!

@jscheffl jscheffl merged commit 0c354e7 into apache:main Nov 30, 2024
github-actions bot pushed a commit that referenced this pull request Nov 30, 2024
(cherry picked from commit 0c354e7)

Co-authored-by: darkag <darkag@free.fr>
@github-actions
Copy link

Backport successfully created: v2-10-test

Status Branch Result
v2-10-test PR Link

@jscheffl jscheffl added the type:bug-fix Changelog: Bug Fixes label Nov 30, 2024
jscheffl pushed a commit that referenced this pull request Nov 30, 2024
(cherry picked from commit 0c354e7)

Co-authored-by: darkag <darkag@free.fr>
utkarsharma2 pushed a commit that referenced this pull request Dec 4, 2024
(cherry picked from commit 0c354e7)

Co-authored-by: darkag <darkag@free.fr>
utkarsharma2 pushed a commit that referenced this pull request Dec 9, 2024
(cherry picked from commit 0c354e7)

Co-authored-by: darkag <darkag@free.fr>
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues legacy api Whether legacy API changes should be allowed in PR legacy ui Whether legacy UI change should be allowed in PR type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gantt chart flickering and constant rescaling

2 participants