Fix tests badge in README.md #44505
Merged
Fix tests badge in README.md #44505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
When backporting, I guess that it would make more sense to add |
shahar1
force-pushed
the
fix-tests-badge
branch
from
232020b to
1bf8578
Compare
Member
I am okay, but one question do we run schedule runs in v2-10-test? |
Member
Nope. We do it only in main. There is no way to run scheduled runs on non-default branch https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule |
Member
|
NICE ONE ! |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit a242ff6) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Backport successfully created: v2-10-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit a242ff6) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
github-actions bot
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit a242ff6) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
shahar1
added a commit
that referenced
this pull request
Dec 3, 2024
* [v2-10-test] Fix tests badge in README.md (#44505) (cherry picked from commit a242ff6) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> * Adjust badge to `v2-10-test` branch * Update README.md * Fix PYPI README.md --------- Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 4, 2024
* [v2-10-test] Fix tests badge in README.md (#44505) (cherry picked from commit a242ff6) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> * Adjust badge to `v2-10-test` branch * Update README.md * Fix PYPI README.md --------- Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 9, 2024
* [v2-10-test] Fix tests badge in README.md (#44505) (cherry picked from commit a242ff6) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> * Adjust badge to `v2-10-test` branch * Update README.md * Fix PYPI README.md --------- Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently bothered by looking at the tests badge in the
README.mdand see that it always indicates failure.It turns out that the badge's path has been changed a bit, and now depends on the file's path within
.github/workflows(ci.yml), rather than its name (Tests).Edit: opened this PR on the main repo by mistake (used GitHub in-browser editing ability), I'll be more careful next time.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.