Skip to content

Remove AIP-44 from models/variable #44525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Dec 1, 2024
Merged

Remove AIP-44 from models/variable #44525

potiuk merged 1 commit into from
Dec 1, 2024

Conversation

@rawwar
Copy link
Contributor

@rawwar rawwar commented Dec 1, 2024 •
edited
Loading

related to #44436

  • ./airflow/models/variable.py: _set
  • ./airflow/models/variable.py: _update
  • ./airflow/models/variable.py: _delete

@rawwar rawwar marked this pull request as ready for review December 1, 2024 03:20
@rawwar rawwar requested review from XD-DENG and ashb as code owners December 1, 2024 03:20
@rawwar rawwar requested review from jscheffl and potiuk December 1, 2024 03:20
@rawwar rawwar mentioned this pull request Dec 1, 2024
Closed
90 tasks
jscheffl
jscheffl reviewed Dec 1, 2024
View reviewed changes
@potiuk potiuk merged commit 1ce3b79 into apache:main Dec 1, 2024
1 check passed
potiuk added a commit to potiuk/airflow that referenced this pull request Dec 1, 2024
@potiuk
Merge internal methods with public ones in model variables
092cf7f 
Follow up after apache#44525
@potiuk potiuk mentioned this pull request Dec 1, 2024
Merged
potiuk added a commit that referenced this pull request Dec 1, 2024
@potiuk
Merge internal methods with public ones in model variables (#44543)
128cb5c 
Follow up after #44525
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@rawwar @got686-yandex
remove internal_api_call decorator (apache#44525)
4b2c76f
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@potiuk @got686-yandex
Merge internal methods with public ones in model variables (apache#44543
40e4152 
)

Follow up after apache#44525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jscheffl jscheffl jscheffl left review comments

@potiuk potiuk potiuk approved these changes

@XD-DENG XD-DENG Awaiting requested review from XD-DENG

@ashb ashb Awaiting requested review from ashb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rawwar @potiuk @jscheffl