Remove AIP-44 from airflow/sensors/base.py (2nd Attempt) #44529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
the
full tests needed
Contributor
Author
|
Okay, mypy checks again, I'll shortly wait until #44434 is merged, then these problems will be gone with a re-base |
gopidesupavan
approved these changes
Dec 1, 2024
jscheffl
force-pushed
the
feature/remove-internal-api-from-sensors-base-v2
branch
from
198812d to
d1668e9
Compare
potiuk
approved these changes
Dec 1, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #44436
Second attempt of #44518, hoping to NOT hit mypy issues again in all providers. Implemented it as it was prior Internal API w/o touching the sensor interface.