Remove comment about removing eval type backport #44588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to keep eval_type_backport, even if Pydantic 2.10.2 solves some basic backport problems with typing on Python 3.8 and 3.9, there are still some constructs that will raise error if the eval_type_backport are not installed. This caused problems in one of our backport tests in https://github.com/apache/airflow/actions/runs/12105919009/job/33751221753 when new typing construct was added in Edge Provider and when we tried to install Airflow 2.10.3 with new Edge provider without eval_type_backport. However, Pydantis has a fallback conditional code - if it is not able to handle some construct, it will fall back to eval_type_backport in case it is installed. That's why we should not really remve eval_type_backport as dependency from either Airflow 2.10.4 nor 3.0.0.
potiuk
requested review from
XD-DENG,
ashb,
bbovenzi,
bolkedebruin,
dstandish,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
jscheffl,
kaxil,
o-nikolas,
pierrejeambrun,
ryanahamilton,
uranusjr and
vincbeck
as code owners
boring-cyborg
bot
added
area:API
jedcunningham
approved these changes
Dec 3, 2024
utkarsharma2
added
the
changelog:skip
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 4, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.