-
Notifications
You must be signed in to change notification settings - Fork 16.4k
AIP-84 Add external dependencies to GET Structure Data Endpoint #44701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 Add external dependencies to GET Structure Data Endpoint #44701
Conversation
46ee957 to
64f3cc9
Compare
d76d6b1 to
8789aaa
Compare
shubhamraj-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
5ea5c6f to
87b5121
Compare
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing locally, I noticed two issues:
example_external_task_marker_parent: did not have any downstream deps
example_trigger_controller_dag`: the dependency comes back as upstream when it should be downstream
Indeed. That's a limitation we have at the moment in the backend in I will open a dedicated issue to track that because its not straight forward. edit: Dedicated issue here #44879 |
Good catch, fixed, also added a test for that. |
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…he#44701) * Working state * Add tests for external task sensor * Add test for TriggerDagRunOperator * Fix following code review * Update following code review
…he#44701) * Working state * Add tests for external task sensor * Add test for TriggerDagRunOperator * Fix following code review * Update following code review
Related to: #42367
Adds the
external_dependenciesquery parameter.Supports
trigger,sensor,asset,asset_aliases.Sensor is back because
ExternalTaskSensoris creating asensordependency type.For now all that is
externalto the dag, and not specific to thetask_level. Meaning that they are attached to the dag (first task of the dag) and not to the specific tasks. (i.e task outlets for assets for instance)