Skip to content

Conversation

@singhania
Copy link

@singhania singhania commented Jan 10, 2019

Description

  • Key contains try number in long but current changes put that as string because of which keys are not getting removed from running dictionary.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

Key contains try number in long but current changes put that as string because of which keys are not getting removed from running dictionary.
@feluelle
Copy link
Member

Please rename your PR title so that the jira github integration works. Something like [AIRFLOW-3652] Fix label to key method to generate correct key Thank you :)

@singhania singhania changed the title Fixed label to key method to generate correct key [AIRFLOW-3652] Fixed label to key method to generate correct key Jan 18, 2019
@singhania
Copy link
Author

Looks like this PR #4163 fixes the same which I tried to fix here.So closing this PR.

@singhania singhania closed this Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants