Raise deprecation warning when accessing metadata through str #44791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
requested review from
XD-DENG,
ashb,
bbovenzi,
bolkedebruin,
dstandish,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
jscheffl,
kaxil,
o-nikolas,
pierrejeambrun,
potiuk,
ryanahamilton,
uranusjr and
vincbeck
as code owners
boring-cyborg
bot
added
area:API
uranusjr
approved these changes
Dec 9, 2024
uranusjr
removed request for
ashb,
bbovenzi,
bolkedebruin,
ephraimbuddy,
kaxil,
potiuk and
ryanahamilton
uranusjr
removed request for
XD-DENG,
dstandish,
eladkal,
hussein-awala,
jedcunningham,
jscheffl,
o-nikolas,
pierrejeambrun and
vincbeck
jscheffl
approved these changes
Dec 9, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Some tests fail but you probably know how to fix...
Member
Author
I'm not sure at this moment 🤔 but will take a look later today |
pierrejeambrun
approved these changes
Dec 10, 2024
Lee-W
force-pushed
the
deprecate-metadata-string-access
branch
from
fdd6217 to
79ac426
Compare
kaxil
pushed a commit
that referenced
this pull request
Dec 17, 2024
utkarsharma2
added
the
changelog:skip
Arunodoy18
added a commit
to Arunodoy18/airflow
that referenced
this pull request
Dec 16, 2025
… active task_instances This commit fixes a foreign key constraint violation that occurs when running 'airflow db clean' command. The issue happened when: - A dag_version row is old (based on created_at) - A task_instance row is recent (based on start_date) but references the old dag_version - The cleanup tries to delete dag_version first, violating the RESTRICT FK constraint The problem was that dag_version incorrectly listed task_instance in its dependent_tables configuration. However, task_instance has a foreign key TO dag_version (task_instance.dag_version_id -> dag_version.id), making task_instance the referrer, not the dependent. Solution: - Removed task_instance from dag_version's dependent_tables list - This prevents dag_version rows from being deleted when they are still referenced by task_instance rows that don't meet deletion criteria Added test case to verify that dag_version rows are properly preserved when referenced by active task_instances. Fixes: apache#44791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior will be removed in airflow 3 as assets have attributes name and uri, it would be confusing to identify which attribute should be used to filter the right asset
related: #43922, #44639
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.