Set Autocomplete Off on Login Form - Main

[geraj1010]

closes: #44019

Updated main Javascript to apply autocomplete="off" to both username and password inputs on login page. This will help prevent the browser from providing hints for the username (and password), as requested in the Issue.

Based on Flask-AppBuilder source code, i.e. https://github.com/dpgaspar/Flask-AppBuilder/tree/master/flask_appbuilder/templates/appbuilder/general/security (see login_db.html and login_ldap.html), this should work for both AUTH_DB (default) and AUTH_LDAP authentication, since they both apparently use the same HTML elements in the form.

[jscheffl]

I actually am not a fan that autocomplete is turned off just in sake of "security" as usability suffers with this. In my view this is more convenience and is something to be considered on a shared PC... but anyway.

[jscheffl]

Small issue in static check, can you resolve this? Best is to use pre-commit locally then you can catch it before submitting to CI

[geraj1010]

I actually am not a fan that autocomplete is turned off just in sake of "security" as usability suffers with this. In my view this is more convenience and is something to be considered on a shared PC... but anyway.

Yea I can see that. Perhaps maybe next iteration can turn this into a Webserver environment variable/Airflow Configuration setting?

[geraj1010]

Small issue in static check, can you resolve this? Best is to use pre-commit locally then you can catch it before submitting to CI

Right on, thanks for the heads up. All fixed now.

[github-actions]

Backport successfully created: v2-10-test

Status	Branch	Result
✅	v2-10-test