Correct the Session argument's type hint in ApplessSecurityManager #44962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #33901 this was moved to a new file and mistakenly changed to flask_session. It's not clear to me why this didn't cause errors, but it was highlighted in my editor as an invalid type 🤷
ashb
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
eladkal
approved these changes
Dec 16, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…pache#44962) In apache#33901 this was moved to a new file and mistakenly changed to flask_session. It's not clear to me why this didn't cause errors, but it was highlighted in my editor as an invalid type 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #33901 this was moved to a new file and mistakenly changed to
flask_session.
It's not clear to me why this didn't cause errors, but it was highlighted in
my editor as an invalid type 🤷