-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add BigQuery job link #45020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BigQuery job link #45020
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
shahar1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Apache Airflow and thank you for your first contribution!
Overall LGTM, I've got a small question though :)
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
@nakamura1878 Woops, only now I noticed that this PR was targeted at |
Yep - we could do it, but we could also bring it to main (forward-port :) ) without reverting - there is no big harm in getting it in. |
|
I also just noticed it was on the "wrong" branch - but only because I had a test on v2-10-test running that was cancelled due to the merge. |
Apologies for that :) |
No we just keep them here. Would be "too much" cleanup and CI has still a lot of dependencies and cross-checks. |
* Add bigquery job link * Fix BigQuery job detail link formatting
Actually it could be possible eventually. We have been removing all the "remnants" of provider tests from CI and I think with some future refactoring of providers into separate projects (working on it) - it could be possible eventually. I might attempt it as part of #42632 and after #44511 is completed. For now the remaining parts are:
It's actually quite likely that for Airflow 3 we will have "non-providers" code only in |
* Add bigquery job link * Fix BigQuery job detail link formatting Co-authored-by: nakamura1878 <nakamura1878@sansan.com>
* Add bigquery job link * Fix BigQuery job detail link formatting Co-authored-by: nakamura1878 <nakamura1878@sansan.com>
This pull request introduces a new helper class for constructing BigQuery Job Detail Links and integrates it into the existing BigQuery operators and links in the Google Cloud provider for Airflow. The most important changes include the addition of the
BigQueryJobDetailLinkclass, its integration into theBigQueryInsertJobOperator, and the necessary imports and configurations.New feature addition:
BIGQUERY_JOB_DETAIL_LINKconstant to construct URLs for BigQuery Job Detail Links inairflow/providers/google/cloud/links/bigquery.py.BigQueryJobDetailLinkclass to handle the construction and persistence of BigQuery Job Detail Links inairflow/providers/google/cloud/links/bigquery.py.Integration into existing operators:
BigQueryJobDetailLinkinairflow/providers/google/cloud/operators/bigquery.pyto make it available for use in BigQuery operators.operator_extra_linksinBigQueryInsertJobOperatorto includeBigQueryJobDetailLinkinairflow/providers/google/cloud/operators/bigquery.py.executemethod ofBigQueryInsertJobOperatorinairflow/providers/google/cloud/operators/bigquery.py.Configuration update:
BigQueryJobDetailLinkto theextra-linkssection inairflow/providers/google/provider.yamlto ensure it is recognized as an extra link.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.