Add dry run for backfill #45062
Add dry run for backfill #45062
Conversation
prabhusneha
force-pushed
the
backfill_dry_run
branch
from
a7a1efd to
d288934
Compare
prabhusneha
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
Created a separate endpoint for dry run. |
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Thanks, looking nice.
A few improvement suggestions.
|
Note: As PR #45312 has been merged, the code formatting rules have changed for new UI. Please rebase and re-run pre-commit checks to ensure that formatting in folder airflow/ui is adjusted. |
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Overall looking good.
A few suggestions.
I would wait for @dstandish approval before merging that, just to be sure that the backfill logic is correct. (It looks good to me)
dstandish
left a comment
dstandish
left a comment
There was a problem hiding this comment.
only thing i changed is to not lock the dag runs for dry run since it's not necessary.
* Add dry run for backfill --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local> Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
* Add dry run for backfill --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local> Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
* Add dry run for backfill --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local> Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
* Add dry run for backfill --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local> Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
7 participants
Closes #44395
Response:
