Correctly set owners on DagModel after TaskSDK parsing change
#45094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out this behaviour wasn't adequetely tested, at least not using serialized DAGs This test fixes this case, and adds/moves some of the tests from models/test_dag.py into test_collection which more accurately represents where the code it is testing now lives.
ashb
requested review from
bolkedebruin,
ephraimbuddy and
jedcunningham
as code owners
boring-cyborg
bot
added
area:Scheduler
jedcunningham
approved these changes
Dec 19, 2024
ashb
commented
Dec 19, 2024
ashb
commented
Dec 19, 2024
pierrejeambrun
approved these changes
Dec 19, 2024
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…he#45094) * Correctly set `owners` on DagModel after TaskSDK parsing change It turns out this behaviour wasn't adequetely tested, at least not using serialized DAGs This test fixes this case, and adds/moves some of the tests from models/test_dag.py into test_collection which more accurately represents where the code it is testing now lives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out this behaviour wasn't adequetely tested, at least not using
serialized DAGs, and broke as a result of #44972
This test fixes this case, and adds/moves some of the tests from
models/test_dag.py into test_collection which more accurately represents where
the code it is testing now lives.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.