Replacing gunicornmontor with uvicorn.run()#45103
Merged
pierrejeambrun merged 19 commits intoapache:mainfrom Jan 24, 2025
Merged
Replacing gunicornmontor with uvicorn.run()#45103pierrejeambrun merged 19 commits intoapache:mainfrom
pierrejeambrun merged 19 commits intoapache:mainfrom
Conversation
…icorn-with-uvicorn-run
vatsrahul1001
force-pushed
the
replace-gunicorn-with-uvicorn-run
branch
from
1a74394 to
85305fc
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
All for it. 👍
Thanks for the metrics that encourage that this is the good choice.
Just a small question.
…omer/airflow into replace-gunicorn-with-uvicorn-run
pierrejeambrun
approved these changes
Jan 21, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Approved, looks good.
Leaving some time for others to participate in the discussion.
…omer/airflow into replace-gunicorn-with-uvicorn-run
Contributor
Author
Fixed tests after updating |
pierrejeambrun
approved these changes
Jan 24, 2025
Member
|
Ok, I think we left enough time for people to participated in case they feel that some other options are necessary. We can always improve later, merging. |
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
* replace gunicorm with uvicorn.run() * fixing tests * Daemonized fastapi server * fixing setproctitle format * updating setproctitle
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* replace gunicorm with uvicorn.run() * fixing tests * Daemonized fastapi server * fixing setproctitle format * updating setproctitle
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
* replace gunicorm with uvicorn.run() * fixing tests * Daemonized fastapi server * fixing setproctitle format * updating setproctitle
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* replace gunicorm with uvicorn.run() * fixing tests * Daemonized fastapi server * fixing setproctitle format * updating setproctitle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #43035
These are the stats comparing
uvicorn.run()withGunicorn + GunicornMonitorComparison: Uvicorn vs. Gunicorn Performance
Request Statistics
Observations
Response Times:
Failures:
RemoteDisconnectederrors. This could indicate potential issues in connection handling under load.Performance Consistency:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.