-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Ignore deprecations in gcp automl, translate #45128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do we really need to ignore these deprecations? or we should remove those deprecated classes? it looks like they have date mentioned target around sept 2025. |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take a closer look before merging
|
It's ok - it's September 2025 - so they are fine. My question is more why in the original PR the tests did not fail. I am looking into it. |
ah i see it looks like providers tests not triggered in original pr https://github.com/apache/airflow/actions/runs/12431426634/job/34709142003 |
|
looks like selective checks ignoring some of the file checks conditions. trying to look more.. |
|
Fix here #45131 |
|
It was a very subtle combination of two bugs - and it's mostly a by-product of having several different folders where provider files come from. Will be simplified in the future when we implement #44511 (I am working on it already - first PRs are coming shortly on that one). |
https://github.com/apache/airflow/actions/runs/12441141635/job/34737776458
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.