Add full screen view for logs #45183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
bbovenzi
reviewed
Dec 23, 2024
Contributor
|
Note: As PR #45312 has been merged, the code formatting rules have changed for new UI. Please rebase and re-run pre-commit checks to ensure that formatting in folder airflow/ui is adjusted. |
tirkarthi
force-pushed
the
logs-full-screen
branch
from
209fe61 to
d332c7f
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Working as expected.
A few minor suggestions.
This reverts commit 956ff7c.
tirkarthi
force-pushed
the
logs-full-screen
branch
from
d332c7f to
ee5dec2
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Working as expected.
Code looks good too.
pierrejeambrun
approved these changes
Jan 8, 2025
Contributor
Author
|
Thanks @pierrejeambrun and @bbovenzi |
dstandish
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 8, 2025
* Add full screen view for log. * Use text button instead of icon. * Revert "Use text button instead of icon." This reverts commit 956ff7c. * Use icon and revert text button. * Refactor to header component for reuse. Show task tries in fullscreen. * Refactor log content to separate component for reuse.
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
* Add full screen view for log. * Use text button instead of icon. * Revert "Use text button instead of icon." This reverts commit 956ff7c. * Use icon and revert text button. * Refactor to header component for reuse. Show task tries in fullscreen. * Refactor log content to separate component for reuse.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Add full screen view for log. * Use text button instead of icon. * Revert "Use text button instead of icon." This reverts commit 956ff7c. * Use icon and revert text button. * Refactor to header component for reuse. Show task tries in fullscreen. * Refactor log content to separate component for reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #44663 (comment)
It will be useful to have logs open in full screen view to read the logs. Currently the tab and task details are still present on scroll taking more space. Legacy logs page had more screen space which was useful for our users internally. The implementation is simple that uses dialog to display the same code block with wrap and other styles applied in full screen mode.
Notes for reviewer and self :
Full screen