Allow internal retries when pending k8s pod is deleted #45184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
karenbraganz
force-pushed
the
fix-k8s-pod-deletion-task-failure
branch
from
240092f to
545bb84
Compare
RNHTTR
reviewed
Jan 14, 2025
karenbraganz
requested review from
hussein-awala and
jedcunningham
as code owners
RNHTTR
approved these changes
Jan 17, 2025
dimberman
approved these changes
Jan 24, 2025
Contributor
dimberman
left a comment
dimberman
left a comment
There was a problem hiding this comment.
Approved, thank you so much @karenbraganz !!!
utkarsharma2
added
the
changelog:skip
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
* Remove code that fails task upon pending pod deletion * Remove clear_not_launched_queued_tasks * Remove units tests for clear_not_launched_queued_tasks * Remove worker_pods_queued_check_interval configuration * Remove worker_pods_queued_check_interval from provider.yaml --------- Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com> Co-authored-by: Daniel Imberman <daniel.imberman@gmail.com>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Remove code that fails task upon pending pod deletion * Remove clear_not_launched_queued_tasks * Remove units tests for clear_not_launched_queued_tasks * Remove worker_pods_queued_check_interval configuration * Remove worker_pods_queued_check_interval from provider.yaml --------- Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com> Co-authored-by: Daniel Imberman <daniel.imberman@gmail.com>
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
* Remove code that fails task upon pending pod deletion * Remove clear_not_launched_queued_tasks * Remove units tests for clear_not_launched_queued_tasks * Remove worker_pods_queued_check_interval configuration * Remove worker_pods_queued_check_interval from provider.yaml --------- Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com> Co-authored-by: Daniel Imberman <daniel.imberman@gmail.com>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* Remove code that fails task upon pending pod deletion * Remove clear_not_launched_queued_tasks * Remove units tests for clear_not_launched_queued_tasks * Remove worker_pods_queued_check_interval configuration * Remove worker_pods_queued_check_interval from provider.yaml --------- Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com> Co-authored-by: Daniel Imberman <daniel.imberman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Airflow instances with the Kubernetes executor, a task will immediately fail if its worker pod is deleted/ evicted in the pending state. A new worker pod is not spun up to replace it, and the task fails with the below error message.
This failure is triggered by this line in the source code.
If the task is not failed upon worker pod deletion, it will remain in the queued state until it reaches
task_queued_timeout. Once this timeout is reached, internal retries will be allowed due to PR #43520 and a new worker pod will be spun up for the task. Therefore, if the first worker pod was deleted or evicted due to a temporary issue, the task will be able to run on the newly spun up worker pod.In this PR, I have removed the code that fails the task when its pending worker pod is deleted. This will prevent task failures from temporary issues with pending worker pods.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.