Remove redundant check for positional arguments #45193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in the refactor: apache#19965 -- since the `task_decorator_factory` enforces keyword-only parameters for via the `*` in its signature.
kaxil
added
the
changelog:skip
hussein-awala
approved these changes
Dec 24, 2024
kaxil
commented
Dec 25, 2024
Comment on lines
-687
to
-688
| elif python_callable is not None: | ||
| raise TypeError("No args allowed while using @task, use kwargs instead") |
Member
Author
There was a problem hiding this comment.
Aah looks like this was for falsy value like {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in the refactor: #19965 -- since the
task_decorator_factoryenforces keyword-only parameters for via the*in its signature.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.