Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jan 2, 2025

The #45314 introduced the bug where image artifacts were not uploaded alongside cache mount artifacts. It caused all PRs to be tested with "main" version of code.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The apache#45314 introduced the bug where image artifacts were not
uploaded alongside cache mount artifacts. It caused all PRs to be
tested with "main" version of code.
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, nice

@gopidesupavan
Copy link
Member

gopidesupavan commented Jan 2, 2025

Nice, about to get to this one while looking at #44533 :)

HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
The apache#45314 introduced the bug where image artifacts were not
uploaded alongside cache mount artifacts. It caused all PRs to be
tested with "main" version of code.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
The apache#45314 introduced the bug where image artifacts were not
uploaded alongside cache mount artifacts. It caused all PRs to be
tested with "main" version of code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants