fix: spark operator label #45353
Merged
fix: spark operator label #45353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
chenkovsky
requested review from
hussein-awala and
jedcunningham
as code owners
Member
|
Can you add a unit test there to avoid regressions? |
potiuk
approved these changes
Jan 12, 2025
eladkal
force-pushed
the
fix/spark_label
branch
from
ffd26cb to
1fe14b5
Compare
Member
|
Can you please fix static checks @chenkovsky ? As an author, your task is to make things green, so that we can merge it -otherwise we will break other's work. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
* fix: spark operator label * update spark operator * update spark kube * make ci happy * update test * format * format
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
* fix: spark operator label * update spark operator * update spark kube * make ci happy * update test * format * format
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* fix: spark operator label * update spark operator * update spark kube * make ci happy * update test * format * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KubernetesPodOperator renamed create_labels_for_pod, _get_pod_identifying_label_string, but it seems that SparkKubernetesOperator hasn't changed them.