Move update subscription from AzureServiceBusTopicCreateOperator to AdminClientHook
#45367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
perry2of5
changed the title
eladkal
approved these changes
Jan 7, 2025
eladkal
changed the title
AzureServiceBusTopicCreateOperator to AdminClientHook
perry2of5
deleted the
refactor-update-subscription-into-hook-from-operator
branch
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
… `AdminClientHook` (apache#45367) * Fix naming and comment to avoid confusion * Move update-subscription logic to hook (refactor)
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
… `AdminClientHook` (apache#45367) * Fix naming and comment to avoid confusion * Move update-subscription logic to hook (refactor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current update subscription operator calls the azure SDK directly. This refactor moves the calls into the hook.
In addition, it fixes some comments and naming in another test which was confusing (comments and variable names referred to a different feature than the one under test)