Adjust JSX element depth from 5 to 7 #45380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
gopidesupavan
approved these changes
Jan 3, 2025
amoghrajesh
approved these changes
Jan 3, 2025
jscheffl
force-pushed
the
bugfix/adjust-eslint-jsx-depth-to-7
branch
from
0000c69 to
1c7bc7c
Compare
shubhamraj-git
approved these changes
Jan 3, 2025
Contributor
shubhamraj-git
left a comment
shubhamraj-git
left a comment
There was a problem hiding this comment.
+1 Much needed, was often facing this issue.
Thanks for the fix.
Contributor
Author
|
Oh, there are more problems with curent code on main. Seems we need to revert the PR #45273 and make it proper again... |
Contributor
|
Oh, thats strange, static check didn't failed for that PR. |
Contributor
Author
|
There was a bug in CI and checks were skipped :-( |
Contributor
|
Ohh, we need to have it fix, do we have any issue number to track that? |
jscheffl
force-pushed
the
bugfix/adjust-eslint-jsx-depth-to-7
branch
from
1c7bc7c to
5657955
Compare
Contributor
Author
|
Now green! |
Member
|
Nice! |
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merge of PR #45273 the canary failed in UI static checks.
Error run is: https://github.com/apache/airflow/actions/runs/12598486200/job/35113887885
Reason is JSX validation which checks element depth <5 - which in my view does not make sense if we render tables with a few elements that unfortunately easily reach a level of 7 - cutting sub-components does not smell resonable.
Therefore with this PR I propose to change the accepted JSX element depth to 7.
Alternatively we would need to revert and rework the PR #45273 and cut more components to the UI.