-
Notifications
You must be signed in to change notification settings - Fork 16.4k
fix(cncf-kubernetes): correctly shutdown xcom after job is complete #45455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cncf-kubernetes): correctly shutdown xcom after job is complete #45455
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
I got the following logs when using the original statement ``` docker run -u 1000 -it alpine sh # alpine container seems to be run under uid 1000 in kubernetes sh -c trap "exit 0" INT; while true; do sleep 1; done; ```` ``` kill -2 $(pgrep -u $(whoami) -f 'trap') ``` ``` whoami whoami: unknown uid 1000 ``` ``` pgrep -f 'trap' # returns no processes ``` instead with: ``` kill -2 $(pgrep -u $(id -u) -f 'sh') ``` Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
0023903 to
109d8dd
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
closes: #45452
related: #45053
I fixed a regression we encountered when upgrading to the latest cncf-kubernetes provider
10.1.0I got the following logs when using the original statement
instead with:
it stops the processes as it should.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.