Skip to content

Conversation

@kjuulh
Copy link

@kjuulh kjuulh commented Jan 7, 2025

closes: #45452
related: #45053

I fixed a regression we encountered when upgrading to the latest cncf-kubernetes provider 10.1.0

I got the following logs when using the original statement

docker run -u 1000 -it alpine sh # alpine container seems to be run under uid 1000 in kubernetes
sh -c trap "exit 0" INT; while true; do sleep 1; done;
kill -2 $(pgrep -u $(whoami) -f 'trap')
whoami
whoami: unknown uid 1000
pgrep -f 'trap' # returns no processes

instead with:

kill -2 $(pgrep -u $(id -u) -f 'sh')

it stops the processes as it should.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Jan 7, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 7, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

I got the following logs when using the original statement

```
docker run -u 1000 -it alpine sh # alpine container seems to be run under uid 1000 in kubernetes
sh -c trap "exit 0" INT; while true; do sleep 1; done;
````

```
kill -2 $(pgrep -u $(whoami) -f 'trap')
```

```
whoami
whoami: unknown uid 1000
```

```
pgrep -f 'trap' # returns no processes
```

instead with:

```
kill -2 $(pgrep -u $(id -u) -f 'sh')
```

Signed-off-by: Kasper J. Hermansen <kah@lunar.app>
@eladkal eladkal force-pushed the fix/correctly-shutdown-xcom-after-job branch from 0023903 to 109d8dd Compare January 23, 2025 12:08
@romsharon98 romsharon98 merged commit a6f6ef1 into apache:main Jan 23, 2025
71 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 23, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 27, 2025
gpathak128 pushed a commit to gpathak128/airflow that referenced this pull request Jan 29, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kubernetes XCOM 10.1.0 regresssion, sidecar isn't being shutdown after job is complete

5 participants