Add bundle_name to ParseImportError #45480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
ephraimbuddy
force-pushed
the
bundle_name
branch
from
9e04269 to
b1a8ced
Compare
ephraimbuddy
requested review from
XD-DENG,
ashb,
bbovenzi,
jedcunningham,
jscheffl,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
ephraimbuddy
added
the
legacy api
ephraimbuddy
force-pushed
the
bundle_name
branch
from
b1a8ced to
5a13ee4
Compare
ephraimbuddy
force-pushed
the
bundle_name
branch
from
5a13ee4 to
1aa4c7b
Compare
bbovenzi
reviewed
Jan 14, 2025
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
Do we need to make any changes to the new FastAPI endpoint?
ephraimbuddy
force-pushed
the
bundle_name
branch
from
1aa4c7b to
002359d
Compare
Contributor
Author
Yes. Added the needed changes now |
ephraimbuddy
added
the
legacy ui
jedcunningham
approved these changes
Jan 15, 2025
airflow/migrations/versions/0056_3_0_0_add_bundle_name_to_parseimporterror.py
Outdated
Show resolved
Hide resolved
ephraimbuddy
force-pushed
the
bundle_name
branch
from
002359d to
85d35d7
Compare
This PR adds bundle_name to ParseImportError. Future work would make the filename relative to the bundle path and that means we need to include bundle_name as part of the ParseImportError so that if two DAG files are having the same filename, we could differentiate them by the bundle they belong.
ephraimbuddy
force-pushed
the
bundle_name
branch
from
85d35d7 to
834f7e1
Compare
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
* Add bundle_name to ParseImportError This PR adds bundle_name to ParseImportError. Future work would make the filename relative to the bundle path and that means we need to include bundle_name as part of the ParseImportError so that if two DAG files are having the same filename, we could differentiate them by the bundle they belong. * fixup! Add bundle_name to ParseImportError * fixup! fixup! Add bundle_name to ParseImportError * fixup! fixup! fixup! Add bundle_name to ParseImportError * Fix tests * Move migration * Fix compact tests * Fix fab failures
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
* Add bundle_name to ParseImportError This PR adds bundle_name to ParseImportError. Future work would make the filename relative to the bundle path and that means we need to include bundle_name as part of the ParseImportError so that if two DAG files are having the same filename, we could differentiate them by the bundle they belong. * fixup! Add bundle_name to ParseImportError * fixup! fixup! Add bundle_name to ParseImportError * fixup! fixup! fixup! Add bundle_name to ParseImportError * Fix tests * Move migration * Fix compact tests * Fix fab failures
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Add bundle_name to ParseImportError This PR adds bundle_name to ParseImportError. Future work would make the filename relative to the bundle path and that means we need to include bundle_name as part of the ParseImportError so that if two DAG files are having the same filename, we could differentiate them by the bundle they belong. * fixup! Add bundle_name to ParseImportError * fixup! fixup! Add bundle_name to ParseImportError * fixup! fixup! fixup! Add bundle_name to ParseImportError * Fix tests * Move migration * Fix compact tests * Fix fab failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bundle_name to ParseImportError. Future work would make
the filename relative to the bundle path and that means we need to include
bundle_name as part of the ParseImportError so that if two DAG files are
having the same filename, we could differentiate them by the bundle they belong.
Depends on #45371
Closes: #45474