Improve google credentials error message #45553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
potiuk
force-pushed
the
improve_connection_credential_logging
branch
from
6a855ec to
dfa82a5
Compare
potiuk
requested changes
Jan 10, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
This is bad idea. You are about to reveal keyfile_dict which contains private key in the log.
- Add details to the error message, to track what exact values were provided.
olegkachur-e
force-pushed
the
improve_connection_credential_logging
branch
from
dfa82a5 to
1a09c11
Compare
Contributor
Author
Good point! There definitely was an another way to improve. The code is updated |
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
- Add details to the error message, to track what exact values were provided. Co-authored-by: Oleg Kachur <kachur@google.com>
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
- Add details to the error message, to track what exact values were provided. Co-authored-by: Oleg Kachur <kachur@google.com>
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
- Add details to the error message, to track what exact values were provided. Co-authored-by: Oleg Kachur <kachur@google.com>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
- Add details to the error message, to track what exact values were provided. Co-authored-by: Oleg Kachur <kachur@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.