-
Notifications
You must be signed in to change notification settings - Fork 16.4k
fix: kpo async kube_config_path #45571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: kpo async kube_config_path #45571
Conversation
7d85aff to
f6e0502
Compare
f6e0502 to
e38a66c
Compare
7e297e5 to
5555916
Compare
|
@romsharon98 @amoghrajesh gentle ping :) |
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and it should fix the issue, I just added a comment to reduce redundant code.
|
@romsharon98 @amoghrajesh gentle ping :) |
5555916 to
237bde7
Compare
|
hi @eladkal , could you pls review , thanks |
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes: #44325