Minor improvements to TaskSDK's WatchedSubprocess #45578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of apache#45570 to add some Typehints so my editor (PyCharm) can find `_on_child_started`. Added/Updated docstrings since `WatchedSubprocess` is now a Base class. and removed redundant exception handling for `init_log_file`
boring-cyborg
bot
added
area:Scheduler
kaxil
requested review from
ashb
and removed request for
ephraimbuddy and
jedcunningham
kaxil
commented
Jan 11, 2025
kaxil
commented
Jan 11, 2025
jedcunningham
approved these changes
Jan 11, 2025
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
Follow-up of apache#45570 to add some Typehints so my editor (PyCharm) can find `_on_child_started`. Added/Updated docstrings since `WatchedSubprocess` is now a Base class. and removed redundant exception handling for `init_log_file`
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
Follow-up of apache#45570 to add some Typehints so my editor (PyCharm) can find `_on_child_started`. Added/Updated docstrings since `WatchedSubprocess` is now a Base class. and removed redundant exception handling for `init_log_file`
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
Follow-up of apache#45570 to add some Typehints so my editor (PyCharm) can find `_on_child_started`. Added/Updated docstrings since `WatchedSubprocess` is now a Base class. and removed redundant exception handling for `init_log_file`
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Follow-up of apache#45570 to add some Typehints so my editor (PyCharm) can find `_on_child_started`. Added/Updated docstrings since `WatchedSubprocess` is now a Base class. and removed redundant exception handling for `init_log_file`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #45570 to add some Typehints so my editor (PyCharm) can find
_on_child_started.Added/Updated docstrings since
WatchedSubprocessis now a Base class.and removed redundant exception handling for
init_log_file^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.