Remove classes from typing_compat that can be imported directly
#45589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
requested review from
XD-DENG,
ashb,
bolkedebruin,
eladkal,
ephraimbuddy,
josh-fell,
mobuchowski,
o-nikolas,
pierrejeambrun and
uranusjr
as code owners
boring-cyborg
bot
added
area:API
`Protocol`, `TypedDict` and `runtime_checkable` are directly importable from `typing` module for the Python versions supported by Airflow main and Providers.
jscheffl
approved these changes
Jan 12, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 12, 2025
…ctly (apache#45589)" This reverts commit 6307a12.
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol,TypedDictandruntime_checkableare directly importable fromtypingmodule for the Python versions supported by Airflow main and Providers.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.