Make Python 3.9 default for v2-10-test branch #45599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
eladkal,
jscheffl,
kaxil and
shahar1
and removed request for
ashb and
jedcunningham
Member
Author
|
I think this should be as simple as that one line change @shahar1 :) |
potiuk
force-pushed
the
build-docs-with-python-3.9
branch
from
1ddf5ac to
05e45af
Compare
Member
Author
|
With some unit tests of course :) Let's see - but after removal of the "pull_request_target" - such changes are quite a bit simpler as we have only "current" workflow - not two workflows to synchronize - one from PR and one from branch. |
jscheffl
approved these changes
Jan 12, 2025
potiuk
force-pushed
the
build-docs-with-python-3.9
branch
2 times, most recently
from
f3c42e1 to
dcb299f
Compare
Member
Author
|
OK. One more place where 3.8 had to be changed to 3.9 - we have static checks using it. Also some docs - just in case and error messages pointing to build 3.9 shoudl be updated. Will make @jscheffl 3.8-3.9 PR smaller :) |
potiuk
force-pushed
the
build-docs-with-python-3.9
branch
from
dcb299f to
ebf4787
Compare
Since we are switching to Sphinx7, we need to build docs using Python 3.9. We need to make sure that Python 3.9 is default image.
potiuk
force-pushed
the
build-docs-with-python-3.9
branch
from
ebf4787 to
8eeb012
Compare
utkarsharma2
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are switching to Sphinx7, we need to build docs using Python 3.9. We need to make sure that Python 3.9 is default image.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.