-
Notifications
You must be signed in to change notification settings - Fork 16.4k
(bugfix): replace create_event with send_event in PagerdutyNotifier
#45630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Covers issue #45630 |
eladkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that we didn't catch this when create_event was removed from the hook means that something is not working properly with the tests.
Merging to unblock the notifier but would be cool if someone has the time to look into the tests
create_event with send_event in PagerdutyNotifier
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
.They were just mocking hook's methods not API methods. But the fact is that MyPy should detect it. For some reason it did not. The "self.hook" is clearly Potentially we could mock |
…ier` (apache#45630) * (bugfix): replace `create_event` with `send_event` in `PagerdutyNotifier` --------- Co-authored-by: Brandon Shea <bshea5@gmail.com>
…ier` (apache#45630) * (bugfix): replace `create_event` with `send_event` in `PagerdutyNotifier` --------- Co-authored-by: Brandon Shea <bshea5@gmail.com>
…ier` (apache#45630) * (bugfix): replace `create_event` with `send_event` in `PagerdutyNotifier` --------- Co-authored-by: Brandon Shea <bshea5@gmail.com>
Closes: #45626
As noted in the most recent change log, https://airflow.apache.org/docs/apache-airflow-providers-pagerduty/stable/changelog.html, switch the create_event method to send_event. This PR fixes the provider as it still uses the prior method.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.