Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Jan 16, 2025

This PR is against v2-10-test

I'd like to make sure we deliver deprecation notice as early as possible.
Users should migrate to SmtpNotifier. Email is just another notification integration it should not be favoured by Airflow core.
We have a very nice template introduced in #36226 so migration should be simple enough.

Removal of email integration from main branch will be handled as part of #30531

@uranusjr
Copy link
Member

Not specific to this PR, are patches to v2-10-test at this point going into a 2.10 patch release, or 2.11.0?

@eladkal
Copy link
Contributor Author

eladkal commented Jan 21, 2025

Not specific to this PR, are patches to v2-10-test at this point going into a 2.10 patch release, or 2.11.0?

Depends on what if we decide to do 2.11 - I think this was not yet decided in the last dev call.
Regardless 2.11 branch will be cut from 2.10 branch so from PRs point of view it's the same process for merging

@utkarsharma2
Copy link
Contributor

@eladkal I think we need to add ignore::RemovedInAirflow3Warning in pyproject.py for the tests to pass.

@eladkal
Copy link
Contributor Author

eladkal commented Jan 23, 2025

@eladkal I think we need to add ignore::RemovedInAirflow3Warning in pyproject.py for the tests to pass.

We can't because of

airflow/pyproject.toml

Lines 492 to 499 in f01c53a

# We cannot add warnings from the airflow package into `filterwarnings`,
# because it invokes import airflow before we set up test environment which breaks the tests.
# Instead of that, we use a separate parameter and dynamically add it into `filterwarnings` marker.
forbidden_warnings = [
"airflow.exceptions.RemovedInAirflow3Warning",
"airflow.utils.context.AirflowContextDeprecationWarning",
"airflow.exceptions.AirflowProviderDeprecationWarning",
]

The issue is RemovedInAirflow3Warning already there yet tests are failing

@eladkal
Copy link
Contributor Author

eladkal commented Feb 27, 2025

Closed in favor of #47146

@eladkal eladkal closed this Feb 27, 2025
@eladkal eladkal deleted the email_v2 branch March 17, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants