Add endpoint_prefix to LivyHook
#45811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
eladkal
reviewed
Jan 21, 2025
Lee-W
reviewed
Jan 22, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Overall looks good. 🙂 Let's add unit tests for this change.
Lee-W
approved these changes
Jan 24, 2025
Lee-W
reviewed
Jan 24, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
It seems we still need to fix some CI failure
Contributor
Author
|
yeah looks like a few formatting changes. |
Member
Yep, would be nice if we can take care of it. Thanks! |
gpathak128
force-pushed
the
livy-endpoint-prefix
branch
from
ae75768 to
b485292
Compare
gpathak128
requested review from
Fokko,
XD-DENG,
ashb,
bbovenzi,
bolkedebruin,
dstandish,
ephraimbuddy,
hussein-awala,
jedcunningham,
jscheffl,
mobuchowski,
o-nikolas,
pierrejeambrun,
potiuk,
ryanahamilton and
uranusjr
as code owners
gpathak128
force-pushed
the
livy-endpoint-prefix
branch
from
b485292 to
381a93f
Compare
eladkal
requested review from
Lee-W
and removed request for
XD-DENG,
bbovenzi,
bolkedebruin,
dstandish,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
jscheffl,
mobuchowski,
o-nikolas and
pierrejeambrun
Contributor
Author
|
post re-base some core tests are failing. all the provider tests pass. im stuck on how to fix this. |
added 7 commits
January 30, 2025 08:27
gpathak128
force-pushed
the
livy-endpoint-prefix
branch
from
66fea9a to
965a664
Compare
Contributor
Author
|
@Lee-W looks like this is good to go :) |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Feb 3, 2025
* revert manual changes to the Changelog file * adding tests for livy db hook * adding tests for async livy hook * reformat comment, and fix endpoint_prefix type for livy trigger * formatting changes * remove extra default args from expectation * adding mock patch for mock request --------- Co-authored-by: Giridhar Pathak <gpathak@microsoft.com>
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Feb 3, 2025
* revert manual changes to the Changelog file * adding tests for livy db hook * adding tests for async livy hook * reformat comment, and fix endpoint_prefix type for livy trigger * formatting changes * remove extra default args from expectation * adding mock patch for mock request --------- Co-authored-by: Giridhar Pathak <gpathak@microsoft.com>
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
* revert manual changes to the Changelog file * adding tests for livy db hook * adding tests for async livy hook * reformat comment, and fix endpoint_prefix type for livy trigger * formatting changes * remove extra default args from expectation * adding mock patch for mock request --------- Co-authored-by: Giridhar Pathak <gpathak@microsoft.com>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* revert manual changes to the Changelog file * adding tests for livy db hook * adding tests for async livy hook * reformat comment, and fix endpoint_prefix type for livy trigger * formatting changes * remove extra default args from expectation * adding mock patch for mock request --------- Co-authored-by: Giridhar Pathak <gpathak@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding endpoint_prefix to allow for accessing livy that is behind a reverse proxy and not available on the root path of the server
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.