Use Task SDK's Context dict in models/taskinstance.py
#45834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
force-pushed
the
use-new-context
branch
3 times, most recently
from
0e774a5 to
4f9ace7
Compare
kaxil
force-pushed
the
use-new-context
branch
5 times, most recently
from
f6ac4a6 to
995924e
Compare
This PR ports re-uses the Context dict from the Task SDK in `models/taskinstance.py`. Once, CeleryExecutor & KubernetesExecutor are ported over to Task SDK, we can remove all of this code. This PR unifies some of that code.
kaxil
force-pushed
the
use-new-context
branch
from
995924e to
b64b0b2
Compare
amoghrajesh
approved these changes
Jan 22, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Yeah changes look good. Can we add TODO in taskinstance.py for the parts that we want to undo once Celery / K8s executors are integrated?
Member
Author
Most of that file we get nuked :) |
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 22, 2025
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 22, 2025
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 22, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in apache#45834 Follow-up of apache#45834
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 22, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in apache#45834 Follow-up of apache#45834
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 22, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in apache#45834 Follow-up of apache#45834
kaxil
added a commit
that referenced
this pull request
Jan 22, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in #45834 Follow-up of #45834
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
This PR ports re-uses the Context dict from the Task SDK in `models/taskinstance.py`. Once, CeleryExecutor & KubernetesExecutor are ported over to Task SDK, we can remove all of this code. This PR unifies some of that code.
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in apache#45834 Follow-up of apache#45834
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
This PR ports re-uses the Context dict from the Task SDK in `models/taskinstance.py`. Once, CeleryExecutor & KubernetesExecutor are ported over to Task SDK, we can remove all of this code. This PR unifies some of that code.
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in apache#45834 Follow-up of apache#45834
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This PR ports re-uses the Context dict from the Task SDK in `models/taskinstance.py`. Once, CeleryExecutor & KubernetesExecutor are ported over to Task SDK, we can remove all of this code. This PR unifies some of that code.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in apache#45834 Follow-up of apache#45834
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
This PR ports re-uses the Context dict from the Task SDK in `models/taskinstance.py`. Once, CeleryExecutor & KubernetesExecutor are ported over to Task SDK, we can remove all of this code. This PR unifies some of that code.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in apache#45834 Follow-up of apache#45834
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 28, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in #45834 Follow-up of apache/airflow#45834 GitOrigin-RevId: 2193be2a5e53760ae00d1b85c825087e995f8eb1
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in #45834 Follow-up of apache/airflow#45834 GitOrigin-RevId: 2193be2a5e53760ae00d1b85c825087e995f8eb1
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 21, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in #45834 Follow-up of apache/airflow#45834 GitOrigin-RevId: 2193be2a5e53760ae00d1b85c825087e995f8eb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-uses the Context dict from the Task SDK in
models/taskinstance.py.Once, CeleryExecutor & KubernetesExecutor are ported over to Task SDK, we can remove all of this code. This PR unifies some of that code.
This also uncovered flawed logic where a Task/TI is in running state but DagRun is in Queued or None state!!!
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.