AIP-66: Make DAG callbacks bundle aware #45860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
ephraimbuddy
force-pushed
the
make-callbacks-bundle-aware
branch
from
3ab1310 to
1bd1551
Compare
ephraimbuddy
force-pushed
the
make-callbacks-bundle-aware
branch
5 times, most recently
from
9ffb322 to
06c46f7
Compare
ephraimbuddy
force-pushed
the
make-callbacks-bundle-aware
branch
from
879774e to
0f6beb2
Compare
ephraimbuddy
force-pushed
the
make-callbacks-bundle-aware
branch
from
0f6beb2 to
b48dbaf
Compare
ephraimbuddy
force-pushed
the
make-callbacks-bundle-aware
branch
from
b48dbaf to
8c8a21f
Compare
ephraimbuddy
force-pushed
the
make-callbacks-bundle-aware
branch
4 times, most recently
from
ec5f309 to
b3438c1
Compare
This involves using relative paths in the callbacks, resolving the full path and using the it to queue the callback in the file processor process. Don't serialize dag if running callback Refactor codes and fix tests update callback test Fix typing Don't use relative fileloc yet Add test apply suggestions from code review Fix some tests and require bundle_version in DagCallbackRequest Resolve conflicts and fix tests join load dagversion as part of TI in process executor event
ephraimbuddy
force-pushed
the
make-callbacks-bundle-aware
branch
from
b3438c1 to
50be7e9
Compare
jedcunningham
approved these changes
Feb 4, 2025
jedcunningham
added
full tests needed
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
This involves using relative paths in the callbacks, resolving the full path and using the it to queue the callback in the file processor process.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
This involves using relative paths in the callbacks, resolving the full path and using the it to queue the callback in the file processor process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves using relative paths in the callbacks, resolving the full path and using it to queue the callback in the file processor process.
Closes: #45496