Invalidate task instance query on marking dagrun state to refetch task instance states. #45977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
approved these changes
Jan 23, 2025
bbovenzi
reviewed
Jan 23, 2025
tirkarthi
force-pushed
the
refresh-ti-mark-dagrun
branch
from
3abb947 to
d30f7c9
Compare
…k instance states.
…un on dagrun marking to ensure updated values are fetched.
tirkarthi
force-pushed
the
refresh-ti-mark-dagrun
branch
from
d30f7c9 to
89acd50
Compare
bbovenzi
approved these changes
Feb 5, 2025
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
Let's just get this in and we can clear up our invalidating later.
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
…k instance states. (apache#45977) * Invalidate task instance query on marking dagrun state to refetch task instance states. * Invalidate task instances only for dag and dagrun. Invalidate clear run on dagrun marking to ensure updated values are fetched. * Use constant for key.
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…k instance states. (apache#45977) * Invalidate task instance query on marking dagrun state to refetch task instance states. * Invalidate task instances only for dag and dagrun. Invalidate clear run on dagrun marking to ensure updated values are fetched. * Use constant for key.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…k instance states. (apache#45977) * Invalidate task instance query on marking dagrun state to refetch task instance states. * Invalidate task instances only for dag and dagrun. Invalidate clear run on dagrun marking to ensure updated values are fetched. * Use constant for key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the dagrun is marked as success or failed the corresponding tasks in running or no state will be marked as success or skipped. During clear run the key is invalidated to fetch the updated task state. Similarly on marking the dagrun the key can be used to invalidate the query to fetch updated task states.
airflow/airflow/ui/src/queries/useClearRun.ts
Lines 63 to 68 in 7a28f29