Skip to content

AIP-84 - remove dry_run in post backfill tests#46001

Merged
pierrejeambrun merged 1 commit intoapache:mainfrom
rawwar:kalyan/AIP-84/backfill/dry_run
Jan 24, 2025
Merged

AIP-84 - remove dry_run in post backfill tests#46001
pierrejeambrun merged 1 commit intoapache:mainfrom
rawwar:kalyan/AIP-84/backfill/dry_run

Conversation

@rawwar
Copy link
Contributor

@rawwar rawwar commented Jan 24, 2025

I noticed a dry_run argument being sent in creating backfill tests. It's not part of the request body as per

class BackfillPostBody(BaseModel):
"""Object used for create backfill request."""
dag_id: str
from_date: datetime
to_date: datetime
run_backwards: bool = False
dag_run_conf: dict = {}
reprocess_behavior: ReprocessBehavior = ReprocessBehavior.NONE
max_active_runs: int = 10

We can either add it to the model(but I don't see it being utilized by underlying functionality) or remove it from tests.

Found this issue while working on #44306

@rawwar rawwar requested a review from pierrejeambrun January 24, 2025 04:10
@rawwar rawwar marked this pull request as ready for review January 24, 2025 04:10
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed,thanks.

There is a dedicated endpoint for running backfills in dry_run mode.

@pierrejeambrun pierrejeambrun merged commit 96ca2a6 into apache:main Jan 24, 2025
52 of 72 checks passed
gpathak128 pushed a commit to gpathak128/airflow that referenced this pull request Jan 29, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants