AIP-84 - remove dry_run in post backfill tests#46001
Merged
pierrejeambrun merged 1 commit intoapache:mainfrom Jan 24, 2025
Merged
AIP-84 - remove dry_run in post backfill tests#46001pierrejeambrun merged 1 commit intoapache:mainfrom
pierrejeambrun merged 1 commit intoapache:mainfrom
Conversation
pierrejeambrun
approved these changes
Jan 24, 2025
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a dry_run argument being sent in creating backfill tests. It's not part of the request body as per
airflow/airflow/api_fastapi/core_api/datamodels/backfills.py
Lines 26 to 35 in d460972
We can either add it to the model(but I don't see it being utilized by underlying functionality) or remove it from tests.
Found this issue while working on #44306