-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove email configs, operator and callbacks #46041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- id: check-no-providers-in-core-examples
language: pygrep
name: No providers imports in core example DAGs
description: The core example DAGs have no dependencies other than standard provider or core Airflow
entry: "^\\s*from airflow\\.providers.(?!standard.)"
pass_filenames: true
files: ^airflow/example_dags/.*\.py$
What about pre-installed providers? if we really want to keep the rule as it is, then I will need to update the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do that. We should keep pre-installed to the minimum necessary.
Probably raise this as one of the items in the lazy consensus
037adbf to
4e7df6e
Compare
|
We need also to remove the email and smtp part of airflow.cfg https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#smtp |
|
I merged #47146 |
|
Do we still want to do this? Happy to help if so. |
Yes. we need to sort this one out before RC1 |
|
We never did anything, and now 3.0 is out… What do we do next? |
Move the email util from airflow-core to smtp provider with airflow4 deprecation warning. |
|
We actually already made some changes and deprecated some configs during task sdk implementation. I think this needs to start from scratch. I’m going to do some of the config changes to catch up with task sdk changes first. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
hooray! this surely simplifies things a lot! |
This PR:
email_on_retryandemail_on_failureto notify the users by email in favor of the SMTP notifierEmailOperatorfromairflow.operators.emailin favor ofairflow.providers.smtp.operators.smtp.EmailOperatorcloses: #30530