Skip to content

Conversation

@jason810496
Copy link
Member

related: #46106


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk force-pushed the provider_moving/apache-flink branch from e03f49f to 70ac63b Compare January 27, 2025 22:02
@jason810496 jason810496 force-pushed the provider_moving/apache-flink branch 2 times, most recently from 8c9052b to 589a4b3 Compare January 28, 2025 16:30
@jscheffl jscheffl force-pushed the provider_moving/apache-flink branch from 589a4b3 to cb35e1e Compare January 28, 2025 19:18
@potiuk potiuk force-pushed the provider_moving/apache-flink branch 3 times, most recently from bab3424 to 1a03a4b Compare January 30, 2025 03:49
@jason810496 jason810496 force-pushed the provider_moving/apache-flink branch from 1a03a4b to 0b29aaa Compare January 30, 2025 12:56
Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs one more rebase from main to get some fixes

@jason810496 jason810496 force-pushed the provider_moving/apache-flink branch 3 times, most recently from cd11533 to 37e082d Compare February 1, 2025 14:27
@jason810496
Copy link
Member Author

The Build documentation failure is caused by a doc issue in the Google Provider, and the Build PROD images failure is due to a dependency conflict.

@jason810496
Copy link
Member Author

After rebasing, only the Build PROD images failure is left.

@potiuk
Copy link
Member

potiuk commented Feb 2, 2025

I will have to take a closer look at that after FOSDEM :)

@jason810496
Copy link
Member Author

I will have to take a closer look at that after FOSDEM :)

No worries, thanks for taking a look! Enjoy FOSDEM!

@potiuk
Copy link
Member

potiuk commented Feb 3, 2025

OK. Easy. It will have to wait until cncf.kubernetes is migrated - when cncf.kubernetes is not yet migrated, flink has it as required dependency and it will not see cncf.kubernetes yet as a separate dependency - because cncf.kubernetes is still in providers/src as the "umbrella" provider package. Once cncf.kubernetes is migrated, rebasing this one should fix it.

@potiuk
Copy link
Member

potiuk commented Feb 3, 2025

cc: @o-nikolas ^^

@o-nikolas
Copy link
Contributor

OK. Easy. It will have to wait until cncf.kubernetes is migrated - when cncf.kubernetes is not yet migrated, flink has it as required dependency and it will not see cncf.kubernetes yet as a separate dependency - because cncf.kubernetes is still in providers/src as the "umbrella" provider package. Once cncf.kubernetes is migrated, rebasing this one should fix it.

cc: @o-nikolas ^^

Ack, looks like @hardeybisey has taken on the kubernetes provider! #46045 (comment)

@potiuk
Copy link
Member

potiuk commented Feb 4, 2025

OK. Easy. It will have to wait until cncf.kubernetes is migrated - when cncf.kubernetes is not yet migrated, flink has it as required dependency and it will not see cncf.kubernetes yet as a separate dependency - because cncf.kubernetes is still in providers/src as the "umbrella" provider package. Once cncf.kubernetes is migrated, rebasing this one should fix it.

cc: @o-nikolas ^^

Ack, looks like @hardeybisey has taken on the kubernetes provider! #46045 (comment)

@hardeybisey -> are you working on it? This one blocks us from HDFS move and we have just a few providers left, so that would need a bit quick turnaround ? Or you'd prefer not to block us?

@jason810496
Copy link
Member Author

@hardeybisey -> are you working on it? This one blocks us from HDFS move and we have just a few providers left, so that would need a bit quick turnaround ? Or you'd prefer not to block us?

I could work with it right now.

@jason810496
Copy link
Member Author

@hardeybisey -> are you working on it? This one blocks us from HDFS move and we have just a few providers left, so that would need a bit quick turnaround ? Or you'd prefer not to block us?

Hi @potiuk , the moving CNCF Kubernetes PR is ready ( #46436 ) , run provider test and pass all pre-commit in local.

@hardeybisey
Copy link
Contributor

hardeybisey commented Feb 4, 2025

@hardeybisey -> are you working on it? This one blocks us from HDFS move and we have just a few providers left, so that would need a bit quick turnaround ? Or you'd prefer not to block us?

I could work with it right now.

@jason810496 I was running into some issues while moving it and plan to pick it up later tonight. You can pick it up if you are able to work on it immediately.

@jason810496 jason810496 force-pushed the provider_moving/apache-flink branch from 786c976 to 82846cc Compare February 6, 2025 17:37
@potiuk potiuk merged commit 91d5b70 into apache:main Feb 6, 2025
91 checks passed
insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants