Skip to content

Conversation

@josix
Copy link
Contributor

@josix josix commented Jan 27, 2025

related: #46045, #42523

  • move failing tests to FAB
  • fix unit tests
  • move 3rd-party-license

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Jan 27, 2025

This one will be a bit tricky and I think it will be best to move those failing tests to FAB @vincbeck -> I think that was also your thought ?

@vincbeck
Copy link
Contributor

vincbeck commented Jan 27, 2025

This one will be a bit tricky and I think it will be best to move those failing tests to FAB @vincbeck -> I think that was also your thought ?

Some of these tests yes but some of them will be deleted when the legacy UI is deleted. For example, test_views_variable should not be moved to FAB provider. Actually just test_views_acl and test_views_custom_user_views should be moved. Adding that to my todo list :). (Or happy to review it someone wants to do it :))

@eladkal
Copy link
Contributor

eladkal commented Jan 29, 2025

We need also to move the 3rd party licenses of fab
https://github.com/apache/airflow/blob/main/providers/src/airflow/providers/3rd-party-licenses/LICENSES-ui.txt

@utkarsharma2
Copy link
Contributor

@josix Is there an ETA for us to close this PR?

@potiuk
Copy link
Member

potiuk commented Jan 29, 2025

@josix Is there an ETA for us to close this PR?

FYI: @utkarsharma2 -> if you are asking about release of Airflow - this one has nothing to do. We need to have fab provider released from the providers-fab/v1_5 branch - but this one is not needed for that.

@josix
Copy link
Contributor Author

josix commented Jan 29, 2025

Thanks, everyone, for pointing me in the right direction. I'll continue migrating these tests. A conservative ETA is 2/7. I hope this won't block others' work, but if it does, I can try to finish it earlier.

@josix josix force-pushed the refactor/move-fab-provider-to-new-structure branch from 2336829 to 4757d16 Compare January 29, 2025 19:53
@potiuk potiuk force-pushed the refactor/move-fab-provider-to-new-structure branch 2 times, most recently from 8efb572 to 8f8f2bb Compare January 30, 2025 08:34
@utkarsharma2
Copy link
Contributor

utkarsharma2 commented Jan 30, 2025

FYI: @utkarsharma2 -> if you are asking about release of Airflow - this one has nothing to do. We need to have fab provider released from the providers-fab/v1_5 branch - but this one is not needed for that.

@potiuk It's not related to the release. But another issue I'm facing is that I'm unable to install the providers from the source and without this PR merged to the main branch, I can't install fab provider explicitly as well.

@potiuk
Copy link
Member

potiuk commented Jan 30, 2025

@potiuk It's not related to the release. But another issue I'm facing is that I'm unable to install the providers from the source and without this PR merged to the main branch, I can't install fab providers explicitly as well.

As discussed - I think uv pip install (for speed) and getting rid of --editable install should solve at least the installation problem.

@josix josix force-pushed the refactor/move-fab-provider-to-new-structure branch from 8f8f2bb to 811d880 Compare January 30, 2025 19:28
@josix josix force-pushed the refactor/move-fab-provider-to-new-structure branch 3 times, most recently from 492922d to 8792c3a Compare January 31, 2025 12:47
@josix josix force-pushed the refactor/move-fab-provider-to-new-structure branch from 8792c3a to b05b81a Compare January 31, 2025 12:49
@josix
Copy link
Contributor Author

josix commented Jan 31, 2025

Hi @vincbeck, I've fixed and moved the related tests, could you help review if the change aligns with your thoughts? thanks!

@jscheffl jscheffl merged commit bd2bb90 into apache:main Jan 31, 2025
91 checks passed
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! Thank you for doing it!

@potiuk
Copy link
Member

potiuk commented Feb 1, 2025

Awesome job! Thank you for doing it!

fantastic!

amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Feb 3, 2025
* refactor(providers/fab): move fab provider to new structure

* fix: updated changed path

* refactor: Move FAB test views to provider-specific directory

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure
dabla pushed a commit to dabla/airflow that referenced this pull request Feb 3, 2025
* refactor(providers/fab): move fab provider to new structure

* fix: updated changed path

* refactor: Move FAB test views to provider-specific directory

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
* refactor(providers/fab): move fab provider to new structure

* fix: updated changed path

* refactor: Move FAB test views to provider-specific directory

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
* refactor(providers/fab): move fab provider to new structure

* fix: updated changed path

* refactor: Move FAB test views to provider-specific directory

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure

* fixup! refactor(providers/fab): move fab provider to new structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants