-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Move fab provider to new structure #46144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move fab provider to new structure #46144
Conversation
|
This one will be a bit tricky and I think it will be best to move those failing tests to FAB @vincbeck -> I think that was also your thought ? |
Some of these tests yes but some of them will be deleted when the legacy UI is deleted. For example, |
|
We need also to move the 3rd party licenses of fab |
|
@josix Is there an ETA for us to close this PR? |
FYI: @utkarsharma2 -> if you are asking about release of Airflow - this one has nothing to do. We need to have fab provider released from the |
|
Thanks, everyone, for pointing me in the right direction. I'll continue migrating these tests. A conservative ETA is 2/7. I hope this won't block others' work, but if it does, I can try to finish it earlier. |
2336829 to
4757d16
Compare
8efb572 to
8f8f2bb
Compare
@potiuk It's not related to the release. But another issue I'm facing is that I'm unable to install the providers from the source and without this PR merged to the main branch, I can't install fab provider explicitly as well. |
As discussed - I think |
8f8f2bb to
811d880
Compare
492922d to
8792c3a
Compare
8792c3a to
b05b81a
Compare
|
Hi @vincbeck, I've fixed and moved the related tests, could you help review if the change aligns with your thoughts? thanks! |
vincbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! Thank you for doing it!
fantastic! |
* refactor(providers/fab): move fab provider to new structure * fix: updated changed path * refactor: Move FAB test views to provider-specific directory * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure
* refactor(providers/fab): move fab provider to new structure * fix: updated changed path * refactor: Move FAB test views to provider-specific directory * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure
* refactor(providers/fab): move fab provider to new structure * fix: updated changed path * refactor: Move FAB test views to provider-specific directory * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure
* refactor(providers/fab): move fab provider to new structure * fix: updated changed path * refactor: Move FAB test views to provider-specific directory * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure * fixup! refactor(providers/fab): move fab provider to new structure
related: #46045, #42523
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.