Skip to content

Conversation

@dabla
Copy link
Contributor

@dabla dabla commented Jan 27, 2025

Now that MSGraph has a dedicated connection type with form ui, the proxy parameter get's wrongly returned as a string (or json) while it should be a Python dict, this PR fixes this.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@dabla dabla changed the title refactor: Make sure proxy config parameter is parsed correctly, even if it's a string or json fix: Make sure proxy config parameter is parsed correctly, even if it's a string or json Jan 27, 2025
@eladkal eladkal changed the title fix: Make sure proxy config parameter is parsed correctly, even if it's a string or json fix: KiotaRequestAdapterHook make sure proxy config parameter is parsed correctly, even if it's a string or json Feb 3, 2025
@eladkal eladkal merged commit 40fd35c into apache:main Feb 3, 2025
61 checks passed
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Feb 3, 2025
…rsed correctly, even if it's a string or json (apache#46145)

* refactor: Make sure proxy is configured correctly, even if it's a string or json

---------

Co-authored-by: David Blain <david.blain@infrabel.be>
@dabla
Copy link
Contributor Author

dabla commented Feb 3, 2025

Thx @eladkal

dabla added a commit to dabla/airflow that referenced this pull request Feb 3, 2025
…rsed correctly, even if it's a string or json (apache#46145)

* refactor: Make sure proxy is configured correctly, even if it's a string or json

---------

Co-authored-by: David Blain <david.blain@infrabel.be>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 4, 2025
…rsed correctly, even if it's a string or json (apache#46145)

* refactor: Make sure proxy is configured correctly, even if it's a string or json

---------

Co-authored-by: David Blain <david.blain@infrabel.be>
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
…rsed correctly, even if it's a string or json (apache#46145)

* refactor: Make sure proxy is configured correctly, even if it's a string or json

---------

Co-authored-by: David Blain <david.blain@infrabel.be>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
…rsed correctly, even if it's a string or json (apache#46145)

* refactor: Make sure proxy is configured correctly, even if it's a string or json

---------

Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants