Skip to content

Conversation

@deban9017
Copy link

@deban9017 deban9017 commented Jan 27, 2025

Adding on top of #28052

Added test case for wait_for_completion = True. Previous test was only testing for false.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 27, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jan 27, 2025

Can you please change the title of your PR and commit meaningful ?

@potiuk
Copy link
Member

potiuk commented Jan 27, 2025

Also you have conflicts.

@deban9017 deban9017 changed the title Patch 2 Added test case for wait_for_completion = True Jan 28, 2025
@deban9017 deban9017 changed the title Added test case for wait_for_completion = True Added test case for wait_for_completion = True Jan 28, 2025
@deban9017 deban9017 changed the title Added test case for wait_for_completion = True Added test case for wait_for_completion = True Jan 28, 2025
@deban9017 deban9017 closed this Jan 28, 2025
@deban9017 deban9017 deleted the patch-2 branch January 28, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants