Skip to content

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jan 28, 2025

Add auto refresh to the new UI, starting with the task instance and dag run pages

What should refresh:

  • Task Instance: Header, details, tries and logs
  • Dag Run: Header, details and the list of task instances

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 28, 2025
@bbovenzi bbovenzi changed the title Add autorefresh to Task Instance page Add autorefresh to Task Instance and Dag Run pages Jan 28, 2025
@tirkarthi
Copy link
Contributor

tirkarthi commented Jan 29, 2025

@bbovenzi Will there be a toggle to disable auto refresh that persists across views in 3.0 like legacy UI?

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested and working as expected. Nice.

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jan 29, 2025

@bbovenzi Will there be a toggle to disable auto refresh that persists across views in 3.0 like legacy UI?

Is there a particular use case ? Otherwise IMO that just feels old and outdated without auto-refresh, I would be for completely removing that toggle in airflow 3 UI.

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
@bbovenzi
Copy link
Contributor Author

Yes, I was leaning towards removing the toggle, being smarter with when its used, and if someone doesn't want any autorefresh then they don't need to specify it in their config.

@bbovenzi
Copy link
Contributor Author

Gonna merge but we can keep talking about a pause autorefresh button

@bbovenzi bbovenzi merged commit 05b2305 into apache:main Jan 29, 2025
35 checks passed
@bbovenzi bbovenzi deleted the autorefresh-new-ui branch January 29, 2025 16:45
@tirkarthi
Copy link
Contributor

The old UI used to have auto refresh only on when there is focus on running dagrun in the grid. I remember sometimes there was a trigger in another tab and I used to manually do the toggle. There could be just a manual refresh button in the header instead of a toggle too. I don't have any strong opinion on this. autorefresh toggle also means more code and maintenance to persist the state and if I remember correctly it used to be a provider to the app object. There will be user feedback during testing to see if there is more demand for the component.

Thanks @bbovenzi .

@bbovenzi
Copy link
Contributor Author

I think both of those use cases can be covered with us being smarter on when we invalidate queries and which queries need a refetchInterval function

got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Add autorefresh to task instance page

* Add refresh indicator

* Add dag run page

* Update airflow/ui/src/components/TaskTrySelect.tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

---------

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
dabla pushed a commit to dabla/airflow that referenced this pull request Jan 30, 2025
* Add autorefresh to task instance page

* Add refresh indicator

* Add dag run page

* Update airflow/ui/src/components/TaskTrySelect.tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

---------

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
* Add autorefresh to task instance page

* Add refresh indicator

* Add dag run page

* Update airflow/ui/src/components/TaskTrySelect.tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

---------

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
* Add autorefresh to task instance page

* Add refresh indicator

* Add dag run page

* Update airflow/ui/src/components/TaskTrySelect.tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

---------

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
* Add autorefresh to task instance page

* Add refresh indicator

* Add dag run page

* Update airflow/ui/src/components/TaskTrySelect.tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

---------

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants