-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add autorefresh to Task Instance and Dag Run pages #46213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bbovenzi Will there be a toggle to disable auto refresh that persists across views in 3.0 like legacy UI? |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Tested and working as expected. Nice.
Is there a particular use case ? Otherwise IMO that just feels old and outdated without auto-refresh, I would be for completely removing that toggle in airflow 3 UI. |
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
|
Yes, I was leaning towards removing the toggle, being smarter with when its used, and if someone doesn't want any autorefresh then they don't need to specify it in their config. |
|
Gonna merge but we can keep talking about a pause autorefresh button |
|
The old UI used to have auto refresh only on when there is focus on running dagrun in the grid. I remember sometimes there was a trigger in another tab and I used to manually do the toggle. There could be just a manual refresh button in the header instead of a toggle too. I don't have any strong opinion on this. autorefresh toggle also means more code and maintenance to persist the state and if I remember correctly it used to be a provider to the app object. There will be user feedback during testing to see if there is more demand for the component. Thanks @bbovenzi . |
|
I think both of those use cases can be covered with us being smarter on when we invalidate queries and which queries need a refetchInterval function |
* Add autorefresh to task instance page * Add refresh indicator * Add dag run page * Update airflow/ui/src/components/TaskTrySelect.tsx Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> --------- Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
* Add autorefresh to task instance page * Add refresh indicator * Add dag run page * Update airflow/ui/src/components/TaskTrySelect.tsx Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> --------- Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
* Add autorefresh to task instance page * Add refresh indicator * Add dag run page * Update airflow/ui/src/components/TaskTrySelect.tsx Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> --------- Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
* Add autorefresh to task instance page * Add refresh indicator * Add dag run page * Update airflow/ui/src/components/TaskTrySelect.tsx Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> --------- Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
* Add autorefresh to task instance page * Add refresh indicator * Add dag run page * Update airflow/ui/src/components/TaskTrySelect.tsx Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> --------- Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Add auto refresh to the new UI, starting with the task instance and dag run pages
What should refresh:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.