-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Removing feature: send context in venv operators (using use_airflow_context)
#46306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amoghrajesh
merged 3 commits into
apache:main
from
astronomer:nuke-use-airflow-context-AF3
Feb 3, 2025
Merged
Removing feature: send context in venv operators (using use_airflow_context)
#46306
amoghrajesh
merged 3 commits into
apache:main
from
astronomer:nuke-use-airflow-context-AF3
Feb 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use_airflow_context)
ephraimbuddy
approved these changes
Jan 31, 2025
Member
|
For context on why we are removing this:
Sorry to revert this yet again :( |
Contributor
Author
|
@ephraimbuddy are we good to send this one in? |
Member
|
Makes sense. Thanks for the reasoning @ashb . Should we also add an issue for 3.1 to re-add it ? |
potiuk
approved these changes
Jan 31, 2025
shahar1
approved these changes
Feb 1, 2025
Contributor
Author
amoghrajesh
added a commit
to astronomer/airflow
that referenced
this pull request
Feb 3, 2025
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Feb 3, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 4, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #45739
#41363 is a feature that heavily relied on pydantic models of AIP 44 to do some serialisation magic.
Historically did this:
Since now we do not have the pydantic models of AIP 44 AND the fact that this didnt make it to any release, now is a time to chop it off.
cc: @phi-friday
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.