Remove Alembic migration autogenerated comment #46322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason810496
changed the title
jason810496
force-pushed
the
nit/remove-alembic-migration-autogenerated-comment-for-pr-46009
branch
from
f35189c to
0519abe
Compare
airflow/migrations/versions/0057_3_0_0_add_new_task_instance_field_scheduled_.py
Show resolved
Hide resolved
shahar1
approved these changes
Feb 1, 2025
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Feb 3, 2025
* Remove Alembic migration autogenerated comment in apache#46009 * Add new erd hash
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Feb 3, 2025
* Remove Alembic migration autogenerated comment in apache#46009 * Add new erd hash
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
* Remove Alembic migration autogenerated comment in apache#46009 * Add new erd hash
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* Remove Alembic migration autogenerated comment in apache#46009 * Add new erd hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rebasing #45961 to the latest main branch and resolving the migration file conflict, I found that the comment was not removed.
related: #46009
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.