Skip to content

Conversation

@0BVer
Copy link
Contributor

@0BVer 0BVer commented Feb 3, 2025

This update revises the documentation for worker_refresh_batch_size to clearly state:

"Number of workers to refresh at a time through Gunicorn's built-in worker management. When set to 0, worker refresh is disabled. When nonzero, Airflow periodically refreshes webserver workers by bringing up new ones and killing old ones."

The change aims to eliminate ambiguity by clarifying that Gunicorn reload and webserver refresh refer to the same underlying mechanism. Previously, these terms could be misinterpreted as distinct functions or mistaken for auto_refresh_interval, leading to confusion. By emphasizing that both phenomena are part of Gunicorn's worker management strategy, users will have a clearer understanding of how Airflow manages webserver workers.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 3, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@0BVer 0BVer marked this pull request as draft February 6, 2025 01:47
@0BVer 0BVer marked this pull request as ready for review February 6, 2025 01:52
@0BVer 0BVer marked this pull request as draft February 6, 2025 02:07
@0BVer 0BVer marked this pull request as ready for review February 6, 2025 05:26
@0BVer
Copy link
Contributor Author

0BVer commented Feb 6, 2025

I applied pre-commit

@potiuk potiuk merged commit 09ba0b1 into apache:main Feb 6, 2025
45 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 6, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
@0BVer 0BVer deleted the patch-1 branch February 7, 2025 04:53
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants