Render a pod spec using the pod_template_file override, if passed to the executor
#46374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brouberol
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
brouberol
force-pushed
the
issue-46373
branch
3 times, most recently
from
562f04f to
01bb5ab
Compare
brouberol
changed the title
pod_template_file override, if passed to the executor
brouberol
force-pushed
the
issue-46373
branch
2 times, most recently
from
8d34bab to
1f71b35
Compare
potiuk
approved these changes
Feb 5, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
That looks good to me but I'd love others (@hussein-awala ?) to take a look?
nevcohen
reviewed
Feb 6, 2025
providers/src/airflow/providers/cncf/kubernetes/template_rendering.py
Outdated
Show resolved
Hide resolved
brouberol
force-pushed
the
issue-46373
branch
3 times, most recently
from
dba7c1d to
b3ba3ef
Compare
Contributor
Author
The documentation is actually quite good there! I did add a mention related to the non default |
…the executor If a task was created by a custom `executor_options['pod_template_file']` option, we make sure to render the `TaskInstance`'s associated `k8s_pod_spec` with this specific `pod_template_file`, to avoid seeing discrepancies between the spec visible in airflow and the one deployed to Kubernetes. Signed-off-by: Balthazar Rouberol <brouberol@wikimedia.org>
brouberol
force-pushed
the
issue-46373
branch
from
b3ba3ef to
183fe66
Compare
eladkal
approved these changes
Feb 9, 2025
vargacypher
pushed a commit
to vargacypher/airflow
that referenced
this pull request
Feb 9, 2025
…sed to the executor (apache#46374) If a task was created by a custom `executor_options['pod_template_file']` option, we make sure to render the `TaskInstance`'s associated `k8s_pod_spec` with this specific `pod_template_file`, to avoid seeing discrepancies between the spec visible in airflow and the one deployed to Kubernetes. Signed-off-by: Balthazar Rouberol <brouberol@wikimedia.org>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…sed to the executor (apache#46374) If a task was created by a custom `executor_options['pod_template_file']` option, we make sure to render the `TaskInstance`'s associated `k8s_pod_spec` with this specific `pod_template_file`, to avoid seeing discrepancies between the spec visible in airflow and the one deployed to Kubernetes. Signed-off-by: Balthazar Rouberol <brouberol@wikimedia.org>
wmfgerrit
pushed a commit
to wikimedia/operations-deployment-charts
that referenced
this pull request
Mar 17, 2025
This will give us the k8s pod spec fix we sent in apache/airflow#46374. Signed-off-by: Balthazar Rouberol <brouberol@wikimedia.org> Bug: T388378 Change-Id: I97f66eb0ac879a5bbdb297730e11f8fc66a094a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a task was created by a custom
executor_options['pod_template_file']option, we make sure to render theTaskInstance's associatedk8s_pod_specwith this specificpod_template_file, to avoid seeing discrepancies between the spec visible in airflow and the one deployed to Kubernetes.After having deployed this patch to my test instance running in our Kubernetes cluster, the 2 fields that were missing from the
K8s Pod Specpane were now visible (namely, thekubeapi_enabledlabel in the following screenshot).closes: #46373