AIP-83 Logical date should be required field when triggering run via API #46390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stronomer/airflow into restore-unique-constraint-logical-date
…que-constraint-logical-date
…stronomer/airflow into restore-unique-constraint-logical-date
…que-constraint-logical-date
…stronomer/airflow into refactor-backfill-reprocess-logic
…omer/airflow into refactor-backfill-reprocess-logic
… of github.com:astronomer/airflow into make-logical-date-as-required-field-to-trigger-dag-api
pierrejeambrun
approved these changes
Feb 7, 2025
Member
There was a problem hiding this comment.
Looking good from the AIP stand point.
Logic looks good too but I would be more confortable if some AIP-83 owner could double check.
cc: @dstandish @uranusjr
I think we need to wait for #46398 before merging so we don't have to create a new PR afterwards.
1 task
uranusjr
reviewed
Feb 10, 2025
uranusjr
reviewed
Feb 10, 2025
uranusjr
reviewed
Feb 10, 2025
uranusjr
reviewed
Feb 10, 2025
uranusjr
reviewed
Feb 10, 2025
uranusjr
reviewed
Feb 10, 2025
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Almost good, just one question on removed run_id logic.
Contributor
Author
Replied here |
Lee-W
reviewed
Feb 10, 2025
Contributor
Author
|
@uranusjr I was testing this and found that the DAG run is being inserted into the |
Contributor
Author
Lee-W
approved these changes
Feb 10, 2025
Member
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
uranusjr
deleted the
make-logical-date-as-required-field-to-trigger-dag-api
branch
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…API (apache#46390) * restore unique constraint on logical date and make it nullable * restore unique constraint on logical date and make it nullable * fix migration file * fix migration file * refactor backfill reprocess logic * fixing tests * fix tests * remove default date from logical date in dag run model * fix task_filter * fix failing tests * make logical date as required field * refactor * remove backfill related changes * implement review comments * add time now to var * fix tests * fix review comments * Update tests/api_fastapi/core_api/routes/public/test_dag_run.py Co-authored-by: Wei Lee <weilee.rx@gmail.com> --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes:#46188
depends: #46295
API request with the logical date as null
API request with the logical date as not null
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.