AIP-82 Introduce BaseEventTrigger as base class for triggers used with event driven scheduling
#46391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
bolkedebruin,
eladkal,
ephraimbuddy,
jedcunningham and
o-nikolas
as code owners
boring-cyborg
bot
added
area:DAG-processing
area:providers
area:serialization
area:task-sdk
provider:amazon
vincbeck
force-pushed
the
vincbeck/base_event_trigger
branch
3 times, most recently
from
823cf8f to
9747cfe
Compare
vincbeck
force-pushed
the
vincbeck/base_event_trigger
branch
from
9747cfe to
0c063ba
Compare
…ith event driven scheduling
vincbeck
force-pushed
the
vincbeck/base_event_trigger
branch
from
0c063ba to
3272a88
Compare
ashb
reviewed
Feb 4, 2025
providers/standard/src/airflow/providers/standard/triggers/file.py
Outdated
Show resolved
Hide resolved
vincbeck
force-pushed
the
vincbeck/base_event_trigger
branch
from
c9a4a30 to
7df99de
Compare
vincbeck
force-pushed
the
vincbeck/base_event_trigger
branch
from
7df99de to
174aa87
Compare
Contributor
Author
Lee-W
reviewed
Feb 12, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
no major issue on my end. looks good. left a few nitpicks
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…ith event driven scheduling (apache#46391)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the lazy consensus thread, we need to create a new base class
BaseEventTrigger. This new base class allows categorizing triggers suitable for event driven scheduling usage. Not all triggers should be used to schedule DAGs,BaseEventTriggeris making this categorization.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.